OpenTreeMap / otm-core / 2947 / 1
84%
develop: 84%

LAST BUILD BRANCH: dependabot/npm_and_yarn/sockjs-0.3.21
DEFAULT BRANCH: develop
Ran
Files 216
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.424% (+0.001%) from 83.423%
2947.1

push

travis-ci

RobinIsTheBird 
WIP update HStore

Changes
-------
- Remove a bad migration
- Fix dependency in the species migration
- Migrate HStoreFields for both UDFModel and UserDefinedCollectionValue
- Include scalar int udf test in `test_udfs`
- Improve udf reverse clean, although it still fails on
  treemap.tests.test_udfs.ScalarUDFFilterTest.test_has_key
- Fixes to `UserDefinedFieldDefinition.reverse_clean` for date udfs
- Fix both `treemap.udf.UDFModel.hstore_udfs` and the associated migration
  to have a callable `default`, in order to be reentrant.
- Fix the migration that gave the old `UDFField` a `default` to be
  reentrant
- Fix `UserDefinedFieldDefinition._update_choice_scalar` so that the
  `UdfsProxy` cleans and reverse cleans against the right datatype
- Add a `'multichoice'` test to `test_udfs`
- Test for a multichoice option with double quotes in the search string
- Fix `test_udfs.ScalarUDFFilterTest.test_float_gt_and_lte_constraints`
  to use the `float__` Transform
- Still removing references to the 'user' datatype from `test_udfs`
- `treemap.udf.UDFModel.UdfsProxy.__delitem__`
- `treemap.models.Species` has to `populate_previous_state()`
- `treemap.search` casts to `float` for numeric min max
- `treemap.udf.UDFModel` implements `__getattr__` to lookup attributes
  corresponding to custom fields
- test custom field attribute in `test_udfs`

- Remove pending tests from `test_audit`
- `treemap.models.ITreeCodeOverride` has to `populate_previous_state`
- Make getting udfs safe for `__getattr__`
- Remove TODOs about restoring the `readonly` field in the importer
- Test value `is None` instead of relying on falsy values, which
  could be legitimate
- Cache the name used in `udf_defs` queries in the model `__dict__`
  to avoid `__getattr__` recursion
- Fix `otm1_migrator` to initialize models with the `instance`
- Refine `otm1_migrator` test for whether to pass instance to
  model creation
- Correct `api.tests` to use the correct form of a `multichoice` udf
- `UserDefinedFieldDefinition.clean_value` now raises `ValidationError`
  exceptions that contain a well formed `message_dict`, aka `error_dict`
- Adapt `treemap.views.map_feature.update_map_feature` to include
  `ValidationError` `message_dict`s from setting a udf to an invalid value
  in its `errors`.
- Refine error return value from `importer.models.trees` to match test
- Change `form_extras` to accept `AttributeError` as well as
  `ObjectDoesNotExist`, as the former is more accurate in this case
- Fix `UDFModel._setup_udf_model_type`

Notes
-----
- The auto-generated migration used `RemoveField` and `AddField`,
  which lost all the data
- The migration here has been hacked to use `RenameField` and `AlterField`,
  and tested for data retention.

Caveats
-------
- Perhaps it's a design flaw that `udfs` perpetually cleans and
  `hstore_udfs` perpetually reverse cleans, and both should be delayed to
  `save_with_user`, but there are disadvantages to allowing dirty values, too.

--

Connects to #1968

17182 of 20596 relevant lines covered (83.42%)

0.83 hits per line

Source Files on job 2947.1