keenlabs / KeenClient-iOS / 738 / 1
66%
master: 66%

Ran 11 May 2017 09:47PM UTC

Files 13

Run time 1s

Badge

Committed 11 May 2017 09:38PM UTC coverage: 65.882% (-0.09%) from 65.972%

Job # 738.1

Build Type

push

travis-ci

Committed by

Commit Message

General cleanup and Objective-C modernization (#211)

* Don't allow the changing of KeenClient keys using sharedClientWithProjectID:andWriteKey:andReadKey:, after they have been initially set.

* Removed the misleading validateProjectID and validateKey. They were checking for nil and empty string, but were being used in a way that indicated that wasn't clear.

* Reverse the initial check to collapse a large branch. Remove outdated iOS 8 checking code.

* Cleaned up stray *. Removed strong from property declarations as it's the default. Use containsString and hasPrefix instead of range checking.

* Removed strong from property declaration because it's the default. Added check for self in init.

* General cleanup.

* Removed strong from property declarations as it's the default. Removed confusing validate method and just check for nil/empty. No need to init to nil in Objective-C for objects.

* Use self = [super init]; in case someone subclasses someday.

* General cleanup.

* General cleanup.

* General cleanup.

* General cleanup.

* No need to check for nil, a message sent in Objective-C to a nil receiver is a no-op.

* No need for @synthesize. It's automatic for @property.

* No need for @synthesize. It will be provided automatically.

* General cleanup.

* General cleanup.

* Using the NS_UNAVAILABLE anotation, so no one can call the init method. Other assorted minor cleanup.

* Using the NS_UNAVAILABLE anotation, so no one can call the init method. Other assorted minor cleanup.

* General cleanup.

* Bring back iOS 8 checks for now.

* Bring back selector check for now.

* Remove major revision code.

* Revert the test.

Run Details

1736 of 2635 relevant lines covered (65.88%)

45.11 hits per line

Source Files on job 738.1