• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

TryGhost / Ghost-Admin / 2166 / 1
70%
master: 70%

Build:
DEFAULT BRANCH: master
Ran 19 Apr 2017 05:06PM UTC
Files 383
Run time 19s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

19 Apr 2017 05:06PM UTC coverage: 73.229% (+0.03%) from 73.198%
2166.1

push

travis-ci

kirrg001
🐛 fix broken sidebar after successful import (#658)

closes TryGhost/Ghost#8307

- unloading the store and refreshing the `session.user` attribute after an import was triggering a rendering edge case where the style was re-computed and a re-render was attempted after the sidebar has been destroyed
- rather than binding a style attribute directly to a CP in `gh-nav-menu` we pass the menu icon in (using `settings.settledIcon` - see below) and manually set the style attribute via the `didReceiveAttrs` hook so that outside changes don't trigger re-computations when we don't expect them and so we can still react to icons being uploaded or removed
- our usage of `settings.icon` is a bit of an odd situation because it's a link to an external resource that will only resolve correctly after a successful save - if we change `settings.icon` in the local store and the nav menu icon style updates before the save has been completed then the server will give us the old icon. To work around this a `settings.settledIcon` attribute has been added that is only updated when we receive data from the store ensuring that our cache-busting technique works correctly

1368 of 2155 branches covered (63.48%)

3329 of 4546 relevant lines covered (73.23%)

48.04 hits per line

Source Files on job 2166.1
  • Tree
  • List 0
  • Changed 20
  • Source Changed 6
  • Coverage Changed 19
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 2166
  • Travis Job 2166.1
  • 6ef7fcaf on github
  • Prev Job for on master (#2165.1)
  • Next Job for on master (#2168.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc