theyworkforyou
/
shineyoureye-sinatra
/
1290
/
1
100%
master: 99%
master: 99%
|
Ran
|
Files
81
|
Run time
4s
|
Badge
Embed ▾
README BADGES
|
coverage: 100.0%. Remained the same
push
travis-ci
octopusinvitroAdd a person factory This person factory will be in charge of creating new person instances. At the moment we have a coupling with the finder classes and the objects they create (for example, people classes are coupled to person classes because we have an explicit call to `.new` on those classes). This finds us constantly changing these classes when the signature of the created classes changes (for example, having to pass an extra argument to the constructor of the people classes because the created class needs it). See for example commits: 2272b581c and 4367744a2 there are a lot of files that change because we added a new argument to the constructor. This is not a reason for this classes to change (and their tests, and the app.rb, and etc. etc.), so it may be better to create factories to be in charge of that and have the finder classes just ask the factory to create that object for them. This will also simplify the signature of the finder classes, from having a number of arguments that are only used for the creation of those objects to just passing one: the factory.
2373 of 2373 relevant lines covered (100.0%)
353.16 hits per line
Source Files on job 1290.1 (2.3.1)
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|