2
87%
master: 87%

Ran 01 Apr 2017 07:03AM UTC

Files 15

Run time 0s

Badge

Embed ▾

Committed 01 Apr 2017 06:59AM UTC coverage: 87.216%. Remained the same

Job # 180.2

Build Type

Pull #39

travis-ci

Committed by

web-flow

Commit Message

Remove duplicate invocation of getKey() in File::getValueFromCache()

Calling `getKey()` before passing the key to `getFileName()` from `getValueFromCache()` is not only unnecessary, it actually breaks caching if the prefix is not empty.
I discovered this from a slightly different perspective: in my application I had to inherit from `Adapter/File` and override `getKey()` so that it applies `sha1()` to it as I frequently get cache keys with colons and other garbage in them. So as with a non-empty prefix, the key gets mutated in this instance, and then gets mutated yet again by the second `getKey()` call, so the lookup key is actually completely different.

Pull Request Pull Request #39: Remove duplicate invocation of getKey() in File::getValueFromCache()

Run Details

307 of 352 relevant lines covered (87.22%)

20.44 hits per line

desarrolla2 / Cache / 180 / 2
87%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 180.2

desarrolla2 / Cache / 180 / 2 87% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 180.2

desarrolla2 / Cache / 180 / 2
87%
master: 87%

README BADGES
x