1
94%
master: 91%

Ran 28 Mar 2017 08:19PM UTC

Files 28

Run time 1s

Badge

Embed ▾

Committed 28 Mar 2017 08:03PM UTC coverage: 93.544% (+0.2%) from 93.324%

Job # THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Constant modules now reuse suitable existing names (#257)

We were previously writing constants to modules named after their
originating files. This approach was unfortunately too naive because the
resulting module names could conflict with other generated modules that
are spelled the same but different only in letter case.

For example, for a file named `myservice.thrift`:

    const float PI = 3.14
    service MyService {}

We would previously write the constants to `myservice.Myservice`
(`myservice.ex`) and the service definition to `myservice.MyService`
(`my_service.ex`). We now write both to `myservice.MyService` (thanks to
the generator's constants-merging logic) and no longer run into module
name conflicts.

Run Details

652 of 697 relevant lines covered (93.54%)

342.25 hits per line

pinterest / elixir-thrift / 781 / 1
94%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 781.1 (THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker)

pinterest / elixir-thrift / 781 / 1 94% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 781.1 (THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker)

pinterest / elixir-thrift / 781 / 1
94%
master: 91%

README BADGES
x