You are now the owner of this repo.

1
97%
master: 97%

Ran 23 Mar 2017 08:35PM UTC

Files 36

Run time 1s

Badge

Embed ▾

Committed 23 Mar 2017 08:30PM UTC coverage: 96.83%. Remained the same

Job # 1662.1

Build Type

push

travis-ci

Committed by

akshayjshah

Commit Message

Make caller path trimming Windows-compatible (#385)

Go stdlib runtime.Caller() currently returns forward slashes on Windows (see golang/go#3335) which causes EntryCaller.TrimmedPath() to return full paths instead of the expected trimmed paths on Windows. This is because EntryCaller.TrimmedPath() uses os.PathSeparator to trim the path which is '' on Windows. According to the discussion on the Go bug, it seems like os.PathSeparator might be '' in some cases on Unix too so might cause issues on non-Windows platforms too.

This PR replaces the two occurrences of os.PathSeparator with ''/' as that is what runtime.Caller() currently produces on all platforms.

Did not add tests, as the existing tests for TrimmedPath() failed on Windows with master and work with this PR.

Fixes: #382
See also: golang/go#18151

Run Details

2230 of 2303 relevant lines covered (96.83%)

71662.25 hits per line

uber-go / zap / 1662 / 1
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1662.1

uber-go / zap / 1662 / 1 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1662.1

uber-go / zap / 1662 / 1
97%
master: 97%

README BADGES
x