blockchain / My-Wallet-V3 / 2315 / 1

71%

master: 71%

push

travis-ci

refactor(Labels): move address labels to metadata service (#334)

* feat(Wallet): move address labels to metadata service

* Work in progress

* feat(metadata): load from payload

* refactor(AddressHD): new class, fetch balance

* refactor(Addresses): make this._accounts serializable, add and remove label

* feat(Transaction): add account and receive index

* refactor(Account): get last labeled address from wallet.labels

* feat(Address): migrate to KV store, version management

* fix(Labels): don't delete from wallet payload until safe to KV is confirmed

* feat(Metadata): use isMetadataReady instead of isdoubleencrypted

* fix(Metadata): use correct derivation after 2nd password entry

* fix(Labels): also check for undefined in toJSON

* refactor(Labels): addLabel requires maxGap argument

* fix(Labels): setLabel() checks address argument type

* refactor(ExchangeDelegate): use Label methods

* test(AddressHD): 100% coverage

* feat(Labels): use version from object

* test(Labels): renamed spec file, added/repaired 9 tests

* fix(API): Linters are overrated?

* test(Wallet): use loadMetadata in mock

Also remove fdescribe and unneeded strict.

* test(External): repair and add more

* fix(HDAccount): receiveIndex falls back to labels backup

* test(HDAccount): repair and add more

* feat(BlockchainWallet): remove getNotePlaceholder()

* test(BlockchainWallet): repair and add more

* test(ExchangeDelegate): disable tests, will fix before merge

* test(External): remove blank line

* chore(Release): v3.29.0 - address-labels branch

* fix(API): remove accidental test code

* fix(Labels): all() should work for newly added account

* refactor(Labels): cleanup

Based on review by @jtormey

* refactor(External): toJSON undefined without exchange account

* test(ExchangeDelegate): repair broken tests

* test(ExchangeDelegate): increase coverage

* test(Labels): label instance is l instead of e

* test(Label): add reserveReceiveAddress() test

* test(Label): reserve/release receive address

* test(Labels): add save and migration tests

* refactor(Labels): fancier server

* fix(Labels): request My-Wallet-V3 sync when needed

* fix(Labels): syncWallet is not a promise

1091 of 1659 branches covered (65.76%)

3018 of 3861 relevant lines covered (78.17%)

575.59 hits per line