mbland / go-script-bash / 616 / 1
94%
master: 95%

LAST BUILD BRANCH: multiple-script-dirs
DEFAULT BRANCH: master
Ran
Files 59
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.119% (-0.03%) from 93.152%
616.1

push

travis-ci

mbland 
WIP - new: Fix tests under 3.2.57(1)-release

Under Bash 3.2.57(1)-release, `./go test new` was failing with:

```
 ✗ new: tab complete --internal
   (in test file tests/new.bats, line 76)
     `touch "${internal_modules[@]}"' failed
   touch: (/var/folders/dl/0j29q1wd0w715j4gnz5ry_pc0000gn/T/test rootdir/scripts/lib/foo): No such file or directory
 ✗ new: tab complete --public
   (in test file tests/new.bats, line 94)
     `touch "${public_modules[@]}"' failed
   touch: (/var/folders/dl/0j29q1wd0w715j4gnz5ry_pc0000gn/T/test rootdir/lib/xyzzy): No such file or directory
 ✗ new: tab complete --test
   (in test file tests/new.bats, line 112)
     `touch "${test_files[@]}"' failed
   touch: (/var/folders/dl/0j29q1wd0w715j4gnz5ry_pc0000gn/T/test rootdir/tests/frotz.bats): No such file or directory
 ✗ new: tab complete --type
   (in test file tests/new.bats, line 130)
     `touch "${text_files[@]}"' failed
   touch: (/var/folders/dl/0j29q1wd0w715j4gnz5ry_pc0000gn/T/test rootdir/gue/wizard.txt): No such file or directory
```

At first I thought this was the "declare and initialize an array at the
same time" bug from commit b421c7382 and
commit c6bf1cf46, as the workaround was
the same: declare the array on one line, and initialize it on another.
After thinking it through, however, I realized this bug was different,
since the earlier bug had to do with exported arrays not getting
initialized, and these arrays were `local`. On top of that, it appeared
that the brace expansion was to blame, since the arguments to `touch`
appeared to contain outer parentheses.

After reviewing https://tiswww.case.edu/php/chet/bash/CHANGES, this
appeared to be the most likely culprit:

  This document details the changes between this version,
  bash-4.1-alpha, and the previous version, bash-4.0-release.

  bb. Fixed a bug that caused brace expansion to take place too soon in
      some compound array assignments.

Using the methodology described in the log message for commit
99ab7805e, I downloaded the Bash 4.0 and
4.1 sources and patches, and confirmed that the bug manifested under
Bash 4.0.44 (the highest patchlevel for 4.0) and did not manifest under
Bash 4.1.

Also, for future reference, the official Bash git repository is at:

  https://savannah.gnu.org/git/?group=bash
  http://git.savannah.gnu.org/cgit/bash.git

However, neither the patches from
https://mirrors.ocf.berkeley.edu/gnu/bash/ nor the Git repository show a
specific change for the fix, and the diff between 4.0.44 and 4.1 is too
large and difficult to parse to easily identify the fix.

2666 of 2863 relevant lines covered (93.12%)

242.12 hits per line

Source Files on job 616.1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line