2
38%
master: %

Ran 14 Mar 2017 02:15PM UTC

Files 86

Run time 4s

Badge

Embed ▾

Committed 14 Mar 2017 02:11PM UTC coverage: 37.553%. First build

Job # LATEST_GO=true

Build Type

push

travis-ci

Committed by

buger

Commit Message

Fix API reloads and add related tests

It broke because reload functionality was using DefaultServeMux for
routing, but our initial `listen` logic used custom muxer, which is
created automatically if you pass non nil second argument to
`http.Serve`.

Change which broke this functionality (#596) was intended to fix
`panic` caused by multiple registrations of “/“ route handle #531.

We did not noticed this bug because we had no tests covering API
reloads, and this PR adds them as well.

This PR fixes API reloads, and still ensure that no multiple route
registrations will be made. It is achieved by creating new
`newServeMux` and updating `http.DefaultServeMux` with it.

Note that our routing and reload functionality have a lot of
duplication (in 3 places), and should be unified one day. Goal of this
PR is to fix the bug, and not to make refactoring.

Run Details

5366 of 14289 relevant lines covered (37.55%)

0.41 hits per line

TykTechnologies / tyk / 1991 / 2
38%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1991.2 (LATEST_GO=true)

TykTechnologies / tyk / 1991 / 2 38% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1991.2 (LATEST_GO=true)

TykTechnologies / tyk / 1991 / 2
38%
master: %

README BADGES
x