3
88%
dev: 88%

Ran 23 Feb 2017 06:20AM CUT

Files 44

Run time 2s

Badge

Embed ▾

Committed 23 Feb 2017 06:17AM CUT coverage: 87.583% (-0.3%) from 87.889%

Job # 3077.3

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Only create Connection object for active TChannel connections

Currently, we create a Connection object as soon as we have a TCP
connection, and then we try to add more information (such as remote peer
information) to the logging context after the init handshake. This can
lead to data races since we're modifying the logging context while
other goroutines may be logging messages with the same context.

Instead of using locks for the logging context, instead separate the
handshake phase of connections out of Connection.

Fixes #584

Run Details

4246 of 4848 relevant lines covered (87.58%)

3051.9 hits per line

Source Files on job 3077.3

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	reqreswriterstate_string.go	17 - 29	5 - 10	0	5 - 10	0.0
0.0	reqresreaderstate_string.go	17 - 180	5 - 96	0 - 31	5 - 65	0.0 - 6
0.0	retryon_string.go	17 - 102	5 + 4	0	5 + 4	0.0
16.67	stats.go	62 - 171	12 - 123	2 - 81	10 - 42	5115.0 + 5113
37.5	frame_pool.go	87 - 395	24 - 232	9 - 247	15 + 15	9908.0 + 9907
54.39	localip.go	113 + 55	57 + 41	31 + 18	26 + 23	5.0 + 4
66.67	connectionstate_string.go	18 - 481	6 - 257	4 - 206	2 - 51	1712.0 + 1711
66.67	channelstate_string.go	18 - 53	6 - 14	4 - 16	2 + 2	748.0 + 747
68.42	checksum.go	176 + 79	57 + 36	39 + 22	18 + 14	7383.0 + 7382
75.0	connection_direction.go	42 - 26	8 - 30	6 - 32	2 + 2	378.0 + 377

Showing 1 to 10 of 44 entries

uber / tchannel-go / 3077 / 3
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3077.3

uber / tchannel-go / 3077 / 3 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3077.3

uber / tchannel-go / 3077 / 3
88%
dev: 88%

README BADGES
x