1
85%
master: 85%

Ran 18 Feb 2017 07:06PM UTC

Files 7

Run time 0s

Badge

Embed ▾

Committed 18 Feb 2017 06:56PM UTC coverage: 81.053% (+0.5%) from 80.505%

Job # 126.1

Build Type

push

travis-ci

Committed by

diasbruno

Commit Message

[fixed] respect closeTimeoutMS during unmount

Fixes issue #17: "When the modal is unmounted, it will abruptly close,
not waiting for any animations to finish."

The bug was caused by the Modal component unmounting the portal
immediately in `componentWillUnmount` regardless of whether the portal
is currently closing or would animate to close.

Now when a Modal has a non-zero `closeTimeoutMS`, the Modal inspects the
portal state before closing.  If the portal is open or closing, but not
closed, it waits to unmount the portal.  If the portal is open and not
already closing, the Modal calls closeWithTimeout() to trigger the
close.

Adds test to ensure portal DOM persists after Modal is unmounted when
the Modal has a `closeTimeoutMS` set.  Updates existing tests to
properly unmount test Modal instances.

Run Details

231 of 285 relevant lines covered (81.05%)

17.04 hits per line

reactjs / react-modal / 126 / 1
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 126.1

reactjs / react-modal / 126 / 1 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 126.1

reactjs / react-modal / 126 / 1
85%
master: 85%

README BADGES
x