1
68%
develop: 68%

Ran 17 Feb 2017 04:36PM UTC

Files 162

Run time 9s

Badge

Embed ▾

Committed 17 Feb 2017 04:31PM UTC coverage: 52.889% (+0.2%) from 52.726%

Job # 744.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Delete deprecated Account fields (#547) ✂️️

Delete deprecated Account fields

- Replaces references to Account.number with Account.identifier.
- Looks like the d08d0b37788a_.py migration copied account.identifier over to account.number.
- With the deprecated fields gone, the `aws_account.py` (`AWSAccountManager` class)  no longer needs to override `_populate_account()` or `lookup_account_by_identifier()`
- Replace any references to `Account.s3_name` or `Account.role_nam`e with code that checks the custom tags. (If there are queries filtering on these fields, may need to create a sqlalchemy hybrid property/method.)
- Replace `security_monkey.common.untils::add_account()` with `account_manager.create()`. (See `manage.py::add_account()`) https://github.com/Netflix/security_monkey/blob/develop/security_monkey/common/utils.py#L104
- Create a new DB migration:
-- Migration should copy over `Account.s3_name` to new custom tag field
-- Migration should copy over `Account.role_name` to new custom tag field
-- Migration should remove `Account.s3_name` and `Account.role_name` and `Account.number` fields
- Tests pass and travis builds.

Run Details

4733 of 8949 relevant lines covered (52.89%)

0.53 hits per line

Netflix / security_monkey / 744 / 1
68%
develop: 68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 744.1

Netflix / security_monkey / 744 / 1 68% develop: 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 744.1

Netflix / security_monkey / 744 / 1
68%
develop: 68%

README BADGES
x