5
97%
master: 97%

Ran 11 Jan 2017 07:08PM UTC

Files 6

Run time 0s

Badge

Embed ▾

Committed 11 Jan 2017 07:03PM UTC coverage: 31.502% (-61.7%) from 93.237%

Job # 2.2.5

Build Type

Pull #162

travis-ci

Committed by

web-flow

Commit Message

Update fallback host logic to reflect comment

The behavior exhibited by the if statement does not reflect the
description in the comment below it: instead of reusing a fallback host if
it's been in use for less than a minute, it actually reuses the fallback
host only if it was last used more than a minute ago.

This was not caught by the test that was added with it, because the test
logic is faulty as well: the only way it could fail is if the value of
`Time.now` actually decreased over time.

This updates the test to assert that the second call completes in less
than a second, rather than timing out, and updates the logic to continue
to use the current (not first) host if the first host was last called
less than a minute ago.

Finally, the DNS timeout test context is modified to reset the client
and thread local variables before each test, rather than before all of
them; otherwise the timeout in the first test case causes the first
check in the second test case to fail (since the client has already
fallen back to the second host)

Pull Request Pull Request #162: Update fallback host logic to reflect comment

Coverage Stats

195 of 619 relevant lines covered (31.5%)

0.32 hits per line

algolia / algoliasearch-client-ruby / 389 / 5
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 389.5 (2.2.5)

algolia / algoliasearch-client-ruby / 389 / 5 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 389.5 (2.2.5)

algolia / algoliasearch-client-ruby / 389 / 5
97%
master: 97%

README BADGES
x