3
81%
master: %

Ran 11 Jan 2017 12:43AM UTC

Files 135

Run time 16s

Badge

Embed ▾

Committed 11 Jan 2017 12:39AM UTC coverage: 81.73% (-0.7%) from 82.473%

Job # TYPE=test

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

thriftrw: Fix service inheritance and add tests (#695)

This adds tests for the ThriftRW plugin and fixes the issues found by the
tests:

-   Service inheritance has been broken for a while. The generated clients
    don't satisfy the full interface and the servers don't actually register
    the inherited methods.
-   Code generated for empty services fails to compile.

The setup for this test operates similarly to the tests in ThriftRW:

-   There is a golden_test that verifies that the code in internal/tests/ is
    up to date with the current version of thriftrw-plugin-yarpc.
-   There are other tests which validate the code inside internal/tests/. For
    now, we only have roundtrip_test which uses the servers and clients
    generated inside internal/tests/ and asserts different behaviors about
    them.

Run Details

6169 of 7548 relevant lines covered (81.73%)

0.87 hits per line

yarpc / yarpc-go / 3873 / 3
81%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3873.3 (TYPE=test)

yarpc / yarpc-go / 3873 / 3 81% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3873.3 (TYPE=test)

yarpc / yarpc-go / 3873 / 3
81%
master: %

README BADGES
x