catmaid / CATMAID / 2853 / 1
47%
master: 45%

LAST BUILD BRANCH: dev
DEFAULT BRANCH: master
Ran
Files 81
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 47.424%. Remained the same
2853.1

push

travis-ci

tomka 
Graph widget: fix SVG export and add SVG factory

The recent update of Cytoscape.js broke SVG export. Cytoscape.js changed
their CanvasRenderer quite a bit and so our hacks to allow SVG export
had to be updated. Instead of adding yet another heack to make SVG
export work through SVGKit, a custom SVG factory has been created, which
is used to create SVG documents manually. It currently supports basic
text, circle, line and polygon geometries plus labels. This allows us to
create Graph Widget SVGs ourselves and to remove MochiKit along with
SVGKit as a dependency.

The following Graph Widget elements have been tested:

- regular nodes, circle (with label)
- group node, hexagon (with label)
- directed edge, line (with label)
- split node edges
- different colors

Labels are optional, but are centered on top of an element. The
generated SVG file groups nodes/edges along with their labels, this
makes later editing easier. Color, font and font-size are obtained from
Cytoscape.js.

Node that the Graph Widget uses this SVG factory by making use of some
of Cytoscape.js' internal renderer cache. For the sake of quickly fixing
the broken SVG export, our own version of the math (e.g. where are Bezer
control points) has been skipped. This can be done later if we want to
be more independent from Cytoscape.js or if changes in their renderer
break our export again.

Fixes catmaid/CATMAID#1450

5918 of 12479 relevant lines covered (47.42%)

0.47 hits per line

Source Files on job 2853.1