• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bpstein / promodel / 141 / 1
86%
master: 86%

Build:
DEFAULT BRANCH: master
Ran 05 Jan 2017 06:32PM UTC
Files 28
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Jan 2017 06:26PM UTC coverage: 84.1% (-2.1%) from 86.192%
2.3.0

push

travis-ci

ralinc
Fix and improve on Facebook OAuth user authentication

The fix:

- delete the callback_url relative path set in the devise initializer (devise handles
that by the options set in the routing, also Facebook rejects relative
path for callback_url as it has to perform a client-side redirect back
to the application url)

The improvements:

- clean up the devise initializer for Facebook
- DRY out the same repeating code for all oauth providers
- do not allow users with unconfirmed emails to be created
- update the uid and provider attributes of registered users
- use proper naming in User model for oauth object
- use find_by instead of where.first

201 of 239 relevant lines covered (84.1%)

3.58 hits per line

Source Files on job 141.1 (2.3.0)
  • Tree
  • List 0
  • Changed 2
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 141
  • Travis Job 141.1
  • 901db394 on github
  • Prev Job for 2.3.0 on master (#140.1)
  • Next Job for 2.3.0 on master (#142.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc