4
0%
master: 0%

Ran 14 Dec 2016 04:51PM UTC

Files 22

Run time 1s

Badge

Embed ▾

Committed 14 Dec 2016 04:41PM UTC coverage: 79.619%. Remained the same

Job # TOX_ENV=py27-mysql

Build Type

push

travis-ci

Committed by

mistercrunch

Commit Message

Workaround for slices "Not Found" issue in IE <= 11 (#1821)

This should fix issue #1339.

IE 11 and lower has a long standing issue: out-of-document element's
pathname has no leading '/'. See

https://connect.microsoft.com/IE/feedbackdetail/view/1002846/pathname-incorrect-for-out-of-document-elements

And Superset's Slice.jsonEndpoint() method relies on pathname() to build
JSON API URL for slices:

```javascript
      jsonEndpoint() {
        const parser = document.createElement('a');
        parser.href = data.json_endpoint;
        let endpoint = parser.pathname + this.querystring();
        endpoint += '&json=true';
        endpoint += '&force=' + this.force;
        return endpoint;
      },
```

`parser` above is exactly an out-of-document element. Therefore when
running in IE <= 11, Superset would build wrong JSON endpoint URLs,
hence the 404 errors for loading data for slices.

This commit adds a simple workaround when leading '/' is missing in the
value returned by pathname().

Run Details

4219 of 5299 relevant lines covered (79.62%)

0.8 hits per line

airbnb / superset / 5000 / 4
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5000.4 (TOX_ENV=py27-mysql)

airbnb / superset / 5000 / 4 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5000.4 (TOX_ENV=py27-mysql)

airbnb / superset / 5000 / 4
0%
master: 0%

README BADGES
x