akrennmair
/
newsbeuter
/
795
/
8
60%
master: 60%
master: 60%
|
Ran
|
Files
129
|
Run time
6s
|
Badge
Embed ▾
README BADGES
|
coverage: 31.951%. Remained the same
push
travis-ci
MinoruFix #447 The bug was introduced in 26522a931, where I re-wrote `strprintf` to use variadic templates. `strprintf` has an internal buffer of 1024 characters; if formatted string doesn't fit into it, new buffer is allocated and later destroyed. As part of the re-write, I replaced `new` and `delete` with `unique_ptr`, but I failed to update the rest of the function accordingly. Specifically, when it came time to initialize `std::string` out of `unique_ptr`'s contents, I used `operator*` which *only extracts the first symbol*. As a result, any line longer than internal buffer was reduced to its first symbol. `textformatter::format_text_to_list` uses `strprintf` to place input string into a chunk of STFL markup that looks like this: {listitem text:\"Here goes the text\"} Due to the aforementioned bug in `strprintf`, if the input text was long enough, this format turned into a single character "{". STFL tripped over it as described in #447.
3938 of 12325 relevant lines covered (31.95%)
113.9 hits per line
