28
96%
master: 96%

Ran 08 Dec 2016 05:28PM UTC

Files 467

Run time 21s

Badge

Embed ▾

Committed 08 Dec 2016 04:47PM UTC coverage: 93.98% (-0.6%) from 94.554%

Job # TOXENV=py35-dj110head-postgres-noelasticsearch

Build Type

push

travis-ci

Committed by

gasman

Commit Message

Revert #3116 and fix #3076 by changing href="#" to href="javascript:void(0)" instead - fixes #3208

The stopPropagation() call was too eager, as this blocked legitimate clicks on the links in the 'more' dropdown.

Yes, I know javascript:void(0) is evil, but it's less evil than href="#" in that it doesn't have side effects. And if the design calls for an element that has the same styling and interactions as an `<a>` element but just happens to trigger an in-page action rather than navigating to a new URL, I don't see why I should jump through hoops undoing the native style of an alternative element like `<button>` to achieve something that's perfectly simple to do the 'evil' way, and as far as I'm aware has no negative effects other than to cause HTML purists to roll their eyes. SO THERE.

Run Details

30348 of 32292 relevant lines covered (93.98%)

0.94 hits per line

torchbox / wagtail / 7973 / 28
96%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7973.28 (TOXENV=py35-dj110head-postgres-noelasticsearch)

torchbox / wagtail / 7973 / 28 96% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7973.28 (TOXENV=py35-dj110head-postgres-noelasticsearch)

torchbox / wagtail / 7973 / 28
96%
master: 96%

README BADGES
x