• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

01org / ciao / 463 / 3
66%
master: 66%

Build:
Build:
LAST BUILD BRANCH: topic/config-subnet-bits
DEFAULT BRANCH: master
Ran 05 Dec 2016 07:48PM UTC
Files 95
Run time 24s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Dec 2016 07:39PM UTC coverage: 64.019% (+0.008%) from 64.011%
COVERALLS_TOKEN=mwTn1pOFqEOUT13vylZNHq53NanoMznO7

push

travis-ci

tpepper
ciao-controller: honor user specified volume ephemerality/bootability

Prior to me splitting addBlockDevice() out of getStorage, there were a set
of hard coded true/false settings for ephemerality/bootability of a volume
and I just kept those.  But then I noticed that controller_test.go had an
unexpected true/false check and Rob figured it was a copy/paste error in
his commit 37d23ea08 which didn't really
matter because the flags were mostly ignored prior to my patches.

What we really want is the user specified config to be honored.  This patch
removes the hard coded sets of s.Ephemeral and s.Bootable, and has the test
check that the ephemerality after getStorage() is the same as what was
input.

Signed-off-by: Tim Pepper <timothy.c.pepper@linux.intel.com>

13419 of 20961 relevant lines covered (64.02%)

0.69 hits per line

Source Files on job 463.3 (COVERALLS_TOKEN=mwTn1pOFqEOUT13vylZNHq53NanoMznO7)
  • Tree
  • List 0
  • Changed 3
  • Source Changed 1
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 463
  • Travis Job 463.3
  • 532d957f on github
  • Prev Job for COVERALLS_TOKEN=mwTn1pOFqEOUT13vylZNHq53NanoMznO7 on storage (#462.2)
  • Next Job for COVERALLS_TOKEN=mwTn1pOFqEOUT13vylZNHq53NanoMznO7 on storage (#464.3)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc