1
100%
master: 100%

Ran 01 Dec 2016 06:21PM UTC

Files 16

Run time 1s

Badge

Embed ▾

Committed 01 Dec 2016 06:11PM UTC coverage: 100.0%. Remained the same

Job # NO_TESTS_OVER_WIRE=1

Build Type

push

travis-ci

Committed by

escapewindow

Commit Message

allow for three states in the rebuild_gpg_homedirs lockfile

Previously, we had a single lockfile.  This meant we were busy
re-creating the gpg homedirs, so don't duplicate the effort, and
don't try to read from the new homedirs just yet.  Once we were
done rebuilding, we removed the lockfile, so scriptworker could
clean up, and the next rebuild could happen.

However, because there was only two states (locked/unlocked) and
there were potentially three competing actions (rebuild1,
scriptworker copy/cleanup, rebuild2), the latter two raced to
see who could fire first.  And because the copy and cleanup were
not instantaneous, having the second rebuild start nuking the
directory before the copy was finished was a problem.

The solution here is to allow for two states in an existing
lockfile (locked/ready) and the non-existent lockfile makes
three.  A nonexistent lockfile means feel free to launch the
next rebuild, first creating the lockfile.  A locked lockfile
means don't read from the new gpg homedirs, and don't try to
launch a new rebuild.  A ready state means feel free to read
from the new gpg homedirs, but don't start a new rebuild yet.

Run Details

1693 of 1693 relevant lines covered (100.0%)

1.0 hits per line

escapewindow / scriptworker / 424 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 424.1 (NO_TESTS_OVER_WIRE=1)

escapewindow / scriptworker / 424 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 424.1 (NO_TESTS_OVER_WIRE=1)

escapewindow / scriptworker / 424 / 1
100%
master: 100%

README BADGES
x