1
100%
master: 100%

Ran 25 Nov 2016 05:28PM UTC

Files 39

Run time 1s

Badge

Embed ▾

Committed 25 Nov 2016 05:17PM UTC coverage: 100.0%. Remained the same

Job # 272.1

Build Type

push

travis-ci

Committed by

ssoloff

Commit Message

Fix race conditions in client acceptance tests

After changing the build system to Gulp, several client acceptance tests
were observed to intermittently fail.  It is believed the Gulp Cucumber
plugin caused the timing of the tests to change (presumably they are now
running faster because the existing Node process is being forked rather
than spinning up an entirely new Node process via the shell), which
exacerbated the existing race conditions.

The typical race condition involved the Cucumber steps (both When and
Then steps) racing ahead of the expected state of the UI.  For example,
after evaluating two expressions, the test would try to click the Remove
button of the first row in the results table.  However, when the test
loses the race, the second row would have not yet been added.  Thus, the
wrong row was being removed.

This fix changes all assertions to effectively wait for a short period
of time for the assertion to be satisfied.  If the assertion is not
satisfied during that window, it will fail as before as if it were run
synchronously.

Run Details

2048 of 2048 relevant lines covered (100.0%)

6.01 hits per line

ssoloff / dice-server-js / 272 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 272.1

ssoloff / dice-server-js / 272 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 272.1

ssoloff / dice-server-js / 272 / 1
100%
master: 100%

README BADGES
x