1
84%
main: 89%

Ran 16 Nov 2016 05:25AM UTC

Files 1

Run time 0s

Badge

Embed ▾

Committed 16 Nov 2016 05:23AM UTC coverage: 67.626% (-0.06%) from 67.682%

Job # 1123.1

Build Type

push

travis-ci

Committed by

eonarheim

Commit Message

Minimize Sprite#_applyEffects calls (#690)

## Changes:

- In `Actor`, don't reapply effects to drawing in `update` method, do it only in `draw` and if `frames` or `opacity` was changed
- In `Sprite`, always set `_effectsDirty` flag after effects were applied
- Few minor changes, like don't calculate same value twice in same method

It's my attempt to improve things on issue #481. It doesn't close issue completely because source of unnecessary calls to `Sprite#_loadPixels` remains mystery to me, but I was able to reduce amount of `_applyEffects` calls.
I can miss some effects' use cases (although sandbox tests seemed working), so please review this carefully.

Coverage Stats

4441 of 6567 relevant lines covered (67.63%)

162.74 hits per line

excaliburjs / Excalibur / 1123 / 1
84%
main: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1123.1

excaliburjs / Excalibur / 1123 / 1 84% main: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1123.1

excaliburjs / Excalibur / 1123 / 1
84%
main: 89%

README BADGES
x