akrennmair / newsbeuter / 721 / 2

60%

master: 60%

Pull #424

travis-ci

<a href="https://github.com/akrennmair/newsbeuter/commit/<a class=hub.com/akrennmair/newsbeuter/commit/f8177cf17ecf56a7a5d576e29df6450e1d194766">f8177cf17<a href="https://github.com/akrennmair/newsbeuter/commit/f8177cf17ecf56a7a5d576e29df6450e1d194766">&quot;&gt;Don&amp;#39;t use make_parents with the filename

Previously, we were using a, now removed, function called mkdir_p to
create the directories for the podbeuter download. That function had a
bug(or was it a feature?) that always ignored the last part of the path.
This worked with the current setup well since it was only passed paths
that included a filename that should be ignored when created the
directories anyway.

In </a><a class="double-link" href="https://github.com/akrennmair/newsbeuter/commit/<a class="double-link" href="https://github.com/akrennmair/newsbeuter/commit/f1dd88e4a4e31c5945a12cbbef6d99df28cad67d">f1dd88e4a</a>">f1dd88e4a</a><a href="https://github.com/akrennmair/newsbeuter/commit/f8177cf17ecf56a7a5d576e29df6450e1d194766"> it was changed to use
mkdir_parents and mkdir_p was removed. This caused all the files
podbeuter was trying to download to be created as directories instead of
regular files, causing all subsequent attempts to write to them to fail.
Fixes #421

3493 of 11167 relevant lines covered (31.28%)

161.83 hits per line