15
100%
master: 94%

Ran 10 Nov 2016 08:40AM UTC

Files 11

Run time 0s

Badge

Embed ▾

Committed 10 Nov 2016 08:30AM UTC coverage: 97.716%. First build

Job # 2.2, gemfiles/rails4.2.gemfile

Build Type

push

travis-ci

Committed by

take-five

Commit Message

Discard default scope order from recursive query

Given a model with default scope:
```
class LinkedItem < ActiveRecord::Base
  belongs_to :parent, class_name: 'LinkedItem', foreign_key: :parent_id
  default_scope -> { order('name ASC') }
end
```

When trying to build hierarchical query against this model
Builder applied default scope to recursive part of recursive query
which lead to invalid SQL queries:
```
SELECT "linked_items".* FROM "linked_items" INNER JOIN (WITH RECURSIVE "linked_items__recursive" AS ( SELECT "linked_items"."id", "linked_items"."parent_id" FROM "linked_items" WHERE "linked_items"."id" = $1 UNION ALL SELECT "linked_items"."id", "linked_items"."parent_id" FROM "linked_items" INNER JOIN "linked_items__recursive" ON "linked_items__recursive"."parent_id" = "linked_items"."id"  ORDER BY name ASC ) SELECT "linked_items__recursive".* FROM "linked_items__recursive") AS "linked_items__recursive" ON "linked_items"."id" = "linked_items__recursive"."id"
```

This commit removes any default ordering when applying default scope to
CTE terms.

Run Details

385 of 394 relevant lines covered (97.72%)

15.24 hits per line

take-five / activerecord-hierarchical_query / 78 / 15
100%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 78.15 (2.2, gemfiles/rails4.2.gemfile)

take-five / activerecord-hierarchical_query / 78 / 15 100% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 78.15 (2.2, gemfiles/rails4.2.gemfile)

take-five / activerecord-hierarchical_query / 78 / 15
100%
master: 94%

README BADGES
x