4
3%
master: 3%

Ran 08 Nov 2016 06:50AM UTC

Files 218

Run time 10s

Badge

Embed ▾

Committed 08 Nov 2016 06:28AM UTC coverage: 89.326% (+0.02%) from 89.311%

Job # TEST_SUITE=backend

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Typing indicators backend: Pass list of user ids to send_event

send_event() expects a list of user ids (ints) except for the special case
of messages. This commit:
1. Fixes this in the call to send_event() in do_send_typing_notification()
2. Renames the variables in do_send_typing_notification() to better reflect
their content (for example, recipient_ids instead of recipients).
3. Renames the id field in the dicts sent in the typing event body (sender,
recipients) to user_id.
4. Adds assertions to the tests to verify that the tornado event user ids
are the same as the recipients in the event body.
5. Adds assertions to the tests to verify that the tornado event user
ids and the recipient user ids (in the event body) are the same as the
expected user ids (obtained from the emails using
get_user_profile_by_email)
6. Changes all assertTrues to assertEquals in the tests

This fixes #2151.

Run Details

22184 of 24835 relevant lines covered (89.33%)

0.89 hits per line

zulip / zulip / 6762 / 4
3%
master: 3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6762.4 (TEST_SUITE=backend)

zulip / zulip / 6762 / 4 3% master: 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6762.4 (TEST_SUITE=backend)

zulip / zulip / 6762 / 4
3%
master: 3%

README BADGES
x