1
80%
master: 80%

Ran 28 Oct 2016 11:25PM UTC

Files 9

Run time 0s

Badge

Embed ▾

Committed 28 Oct 2016 11:23PM UTC coverage: 81.17%. Remained the same

Job # 204.1

Build Type

push

travis-ci

Committed by

samuel

Commit Message

fix spin in (*Lock).Lock() (#145)

Consider the case where there are two clients contending for a lock.
The first creates  '/lock/00000'
The second creates '/lock/00001'

Now, the first lists the children of '/lock' and sees that it has
created the lock and returns.

The second starts looping through the children in the aforementioned order.
Before the first child is processed we have
lowestSeq=1
prevSeq=0
prevSeqPath=""

Since the first child is '00000' we set lowestSeq=0.
However, prevSeq == s, so the second condition fails and
we don't update the prevSeqPath.

Then we process '00001' and again, since s == seq, so !(s<seq), we again
don't update prevSeqPath.

This leads to a scenario where lowerdown we call GetW("/lock/") instead of GetW("/lock/00000")

Run Details

1263 of 1556 relevant lines covered (81.17%)

4481.57 hits per line

samuel / go-zookeeper / 204 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 204.1

samuel / go-zookeeper / 204 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 204.1

samuel / go-zookeeper / 204 / 1
80%
master: 80%

README BADGES
x