3
88%
dev: 88%

Ran 26 Oct 2016 09:55PM UTC

Files 42

Run time 6s

Badge

Embed ▾

Committed 26 Oct 2016 09:51PM UTC coverage: 86.09% (+0.3%) from 85.772%

Job # 2714.3

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

relay: Fail calls if the dest connection's sendCh is full (#528)

The current behaviour tries to write the frame to sendCh forever, which
can cause issues if the connection is stalled. The current behaviour
with a stalled connection would be:
- S1 calls S2, S2's connection gets stalled (bug in S2, or TCP issue)
- Relay reads from S1's connection, and in the same goroutine tries to
  write it to S2's sendCh
- If the connection is stalled, the write would not make any progress.
- All calls from S1 on that connection are now "stuck" behind the
  stalled connection. The relay would not even see frames (hence no
  stats would be incremented), and no progress would be made till the
  connection was killed.

Instead of trying to write to sendCh forever, we should fail the call
immediately if sendCh is at capacity. Instead of the server timing out,
they will instead see an error from the relay and we'll have stats on
the relay side to detect this.

Run Details

4091 of 4752 relevant lines covered (86.09%)

2766.36 hits per line

uber / tchannel-go / 2714 / 3
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2714.3

uber / tchannel-go / 2714 / 3 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2714.3

uber / tchannel-go / 2714 / 3
88%
dev: 88%

README BADGES
x