2
0%
master: 0%

Ran 25 Oct 2016 05:54PM UTC

Files 20

Run time 1s

Badge

Embed ▾

Committed 25 Oct 2016 05:44PM UTC coverage: 77.813%. Remained the same

Job # TOX_ENV=py34-postgres

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Adjusted top margin of heatmap plot to get it working in V2 (#1361)

* Adjusted top margin of heatmap plot to get it working in V2

Problem:
The heatmap in V2 was shifted towards the top margin of slice
container, this was because in v2 slice name header was part of the
container body, while in v1 the header was separately defined in
explore.html template.

Solution:
To get heatmap properly shown in V2, we need to
take into account the height of the slice_name header. Adding to
margin_top will shift the plot in V1 too, but it won't make a big
difference to the look.

Ideally when we renovate slice container in future PR we would defined a
height for slice_name header and take it into account for all
visualization files.

* Added panel header height to margin_top for explore v2

* Use getBoundingClientRect to get header height

* Use slice-header for id of panel-title

Run Details

3700 of 4755 relevant lines covered (77.81%)

0.78 hits per line

airbnb / superset / 3964 / 2
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3964.2 (TOX_ENV=py34-postgres)

airbnb / superset / 3964 / 2 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3964.2 (TOX_ENV=py34-postgres)

airbnb / superset / 3964 / 2
0%
master: 0%

README BADGES
x