safe-global / safe-queue-service / 41811115453 / 1
94%
main: 94%

DEFAULT BRANCH: main
Ran
Files 87
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.82% (+0.2%) from 93.579%
41811115453.1

push

github

web-flow 
Add script to import transactions from the Transaction Service (#343)

* Add script to import transactions from the Transaction Service

A transaction proposed to the Transaction Service without signatures is
stored there as not trusted, so no PENDING_MULTISIG_TRANSACTION event is
published. When a confirmation makes it trusted, only NEW_CONFIRMATION is
published, and confirmations of unknown transactions are ignored here. The
transaction never reaches the Queue Service (PLA-2282).

- MigrationEventService.import_transaction stores a trusted transaction
  of the Transaction Service with its confirmations. It returns
  imported, already_stored or untrusted. create_transaction_from_legacy
  uses it and checks if the transaction exists without loading it.
- app/scripts/import_transactions.py imports the given hashes of a chain
  and exits with 1 if any of them fails.

* Document the maintenance scripts in the README

Add how to run the scripts in app/scripts, locally and in a Kubernetes
pod, and the arguments of each one. Fix the exclude-newer quarantine (7
days, not 2), use uv sync --frozen in the setup and fix the migrations
text.

* Store the execution of an imported transaction in the same insert

Importing an executed transaction did two commits: the transaction with
its confirmations, then the execution. If the second one failed, the
transaction stayed stored as pending, and running the import again
returned already_stored without fixing it.

- create_with_confirmations takes an optional execution and stores it in
  the same insert. update_with_execution_details uses the same column
  mapping.
- import_transaction only returns already_stored when the transaction is
  stored. Other integrity errors are raised, so the script counts them as
  failed.
- Untrusted transactions are logged at INFO in the event handler.
- The script rejects hashes that are not 64 hex chars and logs the stats
  with plain names.

3537 of 3770 relevant lines covered (93.82%)

0.94 hits per line

Source Files on job 41811115453.1