Kinto / kinto / 41805141851 / 1

100%

master: 100%

push

github

Fix #3800: duplicate records in pagination with sub-millisecond timestamps (#3814)

* Fix #3800: duplicate records in pagination with sub-millisecond timestamps

Since #3645, last_modified filters compare the raw column with
from_epoch(value). Rows written by schema versions before 22 store
clock_timestamp() with a microsecond precision, which as_epoch() rounds
to the nearest millisecond. The epoch returned to clients (and stored in
pagination tokens) could then be greater than the raw timestamp, and
the next page filter (last_modified < from_epoch(epoch)) matched the
last object of the previous page again.

Compare as_epoch(last_modified) exactly, and keep a wider bound on the
raw column so that the last_modified indexes are still used. The same
applies to purge_deleted(before=...).

* Simplify last_modified conditions (review feedback)

Inline the bounds instead of the _EPOCH_INDEX_BOUNDS mapping and helper,
as suggested in review.

1615 of 1615 branches covered (100.0%)

8267 of 8267 relevant lines covered (100.0%)

1.0 hits per line