microsoft / RulesEngine / 41713026625 / 1

95%

master: 97%

push

github

Fix RulesCache.Remove prefix collision and clear stale GlobalParams on workflow update (#758)

* Fix RulesCache.Remove prefix collision and clear stale GlobalParams on workflow update

* Restore original UTF-8 BOM encoding of edited source files

The previous commit re-saved the file without its BOM (and as cp1252
where comments held non-ASCII characters). Restore the original
encoding so the diff only contains the intended change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Match the exact workflow name in RulesCache.Remove and keep globals in step with rules

Compiled-rule keys are "{workflow}-{params}", and workflow names may contain
"-", so a key prefix can't tell workflow "A" from "A-B": removing "A" also
evicted the compiled rules of "A-B". Store the owning workflow name in each
compiled-rules cache entry and remove only the entries whose name matches.

Also update the workflow-level GlobalParams delegate together with the
compiled rules: when the new GlobalParams fail to compile, the previous
version's delegate is now dropped instead of still running next to the
error results, and a rule compilation that throws no longer leaves the
globals delegate one version ahead of the compiled rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: MBrekhof <martin.brekhof@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: YogeshPraj <yoprajap@microsoft.com>

506 of 632 branches covered (80.06%)

900 of 949 relevant lines covered (94.84%)

881.5 hits per line