2
88%
master: 88%

Ran 11 Oct 2016 03:27PM UTC

Files 133

Run time 8s

Badge

Embed ▾

Committed 11 Oct 2016 03:18PM UTC coverage: 0.0%. Remained the same

Job # 410.2

Build Type

push

travis-ci

Committed by

wesm

Commit Message

PARQUET-747: Better hide TypedRowGroupStatistics in public API

EDIT: It appears the linker issue is coming from the use of `TypedRowGroupStatistics<T>::Update` in `WriteBatch`, and Update hasn't been exported. There's some gcc quirks around this (see https://codereview.chromium.org/643703003/), so it's easier to hide the WriteBatch implementation so that `libparquet_arrow` doesn't look for non-exported symbols during linking (since `WriteBatch` was being inlined).

Template subclasses don't behave in the same way with visibility attributes. See also PARQUET-659. Observed in build failure https://circleci.com/gh/conda-forge/staged-recipes/10100

Author: Wes McKinney <wesm@apache.org>

Closes #178 from wesm/PARQUET-747 and squashes the following commits:

8e91f86 [Wes McKinney] Do not expose WriteBatch implementation in public headers
206f4e1 [Wes McKinney] clang format
ed5132d [Wes McKinney] Export single instantiations of TypedRowGroupStatistics with extern templates

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

wesm / parquet-cpp / 410 / 2
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 410.2

wesm / parquet-cpp / 410 / 2 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 410.2

wesm / parquet-cpp / 410 / 2
88%
master: 88%

README BADGES
x