3
81%
master: %

Ran 07 Oct 2016 06:37PM UTC

Files 95

Run time 6s

Badge

Embed ▾

Committed 07 Oct 2016 06:33PM UTC coverage: 92.409% (-0.2%) from 92.631%

Job # TYPE=test

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Consolidate registration methods (#384)

This deprecates encoding-specific Register functions in favor of a single
`Dispatcher.Register` method. So instead of,

    raw.Register(dispatcher, raw.Procedure("foo", fooHandler))
    json.Register(dispatcher, json.Procedure("bar", barHandler))
    thrift.Register(dispatcher, keyvalueserver.New(keyValueHandler))

You now do,

    dispatcher.Register(raw.Procedure("foo", fooHandler))
    dispatcher.Register(json.Procedure("bar", barHandler))
    dispatcher.Register(keyvalueserver.New(keyValueHandler))

Encoding-specific register methods now have a dumb replacement in place which
just calls `dispatcher.Register` to make migration easier.

    func Register(d Dispatcher, rs []Registrant) { d.Register(rs) }

Further, for Thrift, registration options are now provided to `New` rather
than `thrift.Register`:

    // Instead of,
    thrift.Register(dispatcher, keyvalueserver.New(keyValueHandler), thrift.DisableEnveloping)
    
    // You now do,
    dispatcher.Register(keyvalueserver.New(keyValueHandler, thrift.DisableEnveloping))

Note that generated Thrift code will have to be updated because of this
change.

Resolves #379

Run Details

4334 of 4690 relevant lines covered (92.41%)

0.98 hits per line

yarpc / yarpc-go / 1919 / 3
81%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1919.3 (TYPE=test)

yarpc / yarpc-go / 1919 / 3 81% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1919.3 (TYPE=test)

yarpc / yarpc-go / 1919 / 3
81%
master: %

README BADGES
x