• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 38233342502 / 35
85%
main: 85%

Build:
DEFAULT BRANCH: main
Ran 12 Oct 2026 10:29AM UTC
Files 513
Run time 43s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Oct 2026 09:58AM UTC coverage: 43.461% (+0.009%) from 43.452%
38233342502.35

push

github

AkramBitar
fix(storage): harden the KVS-backed identity and wallet stores

The KVS-backed identity and wallet stores reported a storage fault as
absence, so a transient backend failure was indistinguishable from "this
identity is not registered" and could let a caller create a duplicate
wallet.

- WalletStore.IdentityExists returns (bool, error), and the role Registry
  and the mocks follow. An error means the lookup itself failed and the
  answer is unknown; it must not be read as "the binding does not exist".
  The entry is read with kvs.Get rather than probed with kvs.Exists,
  because FSC implements Exists over GetExisting, which drops the
  underlying store error: only a "not found" error is an authoritative
  miss, every other error reaches the caller. GetWalletID classifies
  absence the same way. The driver interface and the SQL backend carry
  this signature already, from #2409.

  FSC has no absence sentinel yet, so that classification has to match on
  the error message, and the match is anchored at both ends rather than
  searching for the "does not exist" substring. A store failure can carry
  that very phrase -- a missing or not-yet-migrated table makes Postgres
  answer `relation "kvs" does not exist` -- and reading it as a miss is
  the duplicate-wallet mode this change exists to close. A backend returns
  its absence error unwrapped, so a miss starts with the sentinel, while a
  failure always arrives wrapped in "failed retrieving state [...]" and
  can never match it, whatever its cause says.

  The anchoring ties the match to the exact wording of the heads it knows,
  which makes it fragile in one direction only, deliberately. A reworded
  absence error has its miss propagated as a hard error, so GetWalletID
  fails for an unbound identity and the Registry aborts the wallet
  creation: loud and recoverable. Widening the match buys that back at the
  price of the opposite failure, ("", nil) for an unreadable store, which
  is the duplicate wall... (continued)

18467 of 42491 relevant lines covered (43.46%)

1204.39 hits per line

Source Files on job itest-dloghsm-fabric-t2-websocket - 38233342502.35
  • Tree
  • List 513
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 38233342502
  • 0dd0f853 on github
  • Prev Job for on main (#38150624384.66)
  • Next Job for on main (#38531046284.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc