mongodb-js / devtools-shared / 37958641139 / 16 – mongodb-schema

80%

main: 80%

push

github

feat(mongodb-runner): locate the DSC directory with --slsDir (#913)

This change makes it easier to start SLS clusters. It adds a new `--slsDir` CLI parameter which takes a path. The runner verifies that the path contains all of the files needed to start an SLS cluster, which are:

* `sls-multicell-docker-compose.yml`
* `slsbackup.proto`
* `flags-state.json`

The latter two files aren't used by the runner, but they're referenced from the `sls-multicell-docker-compose.yml` file, so attempting to start an SLS stack without them present will fail.

It also looks for the `manifest.json` file in this directory and will pull the SLS image tag from it by default. This can still be overridden with an explicit `--slsTag` argument.

This **removes the existing `--slsCompose` argument**. This new `--slsDir` code makes sure that we have everything needed to actually run SLS, so we want to force people to use it.

344 of 375 branches covered (91.73%)

Branch coverage included in aggregate %.

556 of 580 relevant lines covered (95.86%)

1532.32 hits per line