1
95%
master: 87%

Ran 28 Sep 2016 06:48PM UTC

Files 106

Run time 6s

Badge

Embed ▾

Committed 28 Sep 2016 06:41PM UTC coverage: 93.722%. First build

Job # 2.1.4

Build Type

push

travis-ci

Committed by

jgondron

Commit Message

AIMS-358:
-Problem was due to the usage of Batch.current_match. It made an assumption about which match should be modified. If the user clicked on it multiple times, such as in the case of an impatient user clicking the button again before receiving a response, it would receive all of the requests and cause each match in order to be accepted, without the user being aware. Changed it to expect the form to post the match id as a param so that it's explicitly modifying the correct match.
-This still does not prevent the user from clicking multiple times when binning an item. It merely prevents it from modifying the wrong matches when this happens. At worst, it will just make the activity log look odd by having multiple "AssociatedItemAndBin" activities.
-There are additional problems in other parts of the workflow that will be affected by this reliance on Batch.current_match. This commit specifically addresses the part of the workflow affected in AIMS-358. Future commits on this branch will be to correct others.

Run Details

2105 of 2246 relevant lines covered (93.72%)

26.29 hits per line

ndlib / annex-ims / 1520 / 1
95%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1520.1 (2.1.4)

ndlib / annex-ims / 1520 / 1 95% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1520.1 (2.1.4)

ndlib / annex-ims / 1520 / 1
95%
master: 87%

README BADGES
x