valkyrjaio / valkyrja-php / 31072661535 / 1
100%
26.x: 100%

DEFAULT BRANCH: 26.x
Ran
Files 1181
Run time 25s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
31072661535.1

push

github

web-flow 
[Orm] fix: Use the query builder that withWhere returns in findBy and allBy (#1156)

# Description

`findBy()` and `allBy()` called `withWhere()` and discarded the result.
The query builder is immutable: `withWhere()` returns a clone that holds
the where clauses, and the receiver does not change. The prepared query
therefore held no WHERE clause, so `find()` and `findBy()` read the
first row of the whole table, and `allBy()` read every row. The methods
now use the builder that `withWhere()` returns. The updated tests route
`withWhere()` to a distinct builder and assert that `prepare()` receives
the query of that builder; the tests fail against the unfixed code.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/Valkyrja/Orm/Repository/Repository.php`** — `findBy()` and
`allBy()` keep the builder that `withWhere()` returns
- **`tests/Tests/Unit/Orm/Repository/RepositoryTest.php`** — the read
tests assert that `prepare()` receives the query that holds the where
clauses

12681 of 12681 relevant lines covered (100.0%)

24.78 hits per line

Source Files on job 31072661535.1