1
31%
master: 31%

Ran 03 Aug 2026 07:56AM UTC

Files 47

Run time 1s

Badge

Embed ▾

Committed 03 Aug 2026 07:52AM UTC coverage: 31.466% (-0.01%) from 31.476%

Job # 30795271683.1

Build Type

Pull #667

github

Committed by

sairaj18

Commit Message

fix: close rows in runQuery to prevent connection pool leak under db_async

runQuery never called rows.Close(), and Go's database/sql has no
finalizer to do it for you. The rows.Columns() and rows.Scan() error
paths returned early without closing, permanently leaking that
connection's slot in the pool for the life of the process (db.Close()
only reaps idle connections, not ones still marked in-use).

Under db_async with many concurrent fast queries and only 2 idle
connections kept warm by default, each leak forces more simultaneous
new connection handshakes for the remaining queries in the burst,
compounding the driver-level connection-leasing contention described
in #659.

Mirrors the deferred close pattern already used by nri-mssql's
equivalent query path.

Pull Request Pull Request #667: fix: close rows in runQuery to prevent connection pool leak under db_async

Coverage Stats

2011 of 6391 relevant lines covered (31.47%)

9.06 hits per line

newrelic / nri-flex / 30795271683 / 1
31%
master: 31%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job run-linux - 30795271683.1

newrelic / nri-flex / 30795271683 / 1 31% master: 31%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job run-linux - 30795271683.1

newrelic / nri-flex / 30795271683 / 1
31%
master: 31%

README BADGES
x