valkyrjaio / valkyrja-starter-app-php / 30725766232 / 1
100%
26.x: 100%

DEFAULT BRANCH: 26.x
Ran
Files 33
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30725766232.1

push

github

web-flow 
[Provider] refactor: Rename the app providers to carry their component name (#216)

# Description

`valkyrja/phparkitect` v26.6.0 adds a rule that a provider name must
contain its
component name (ci-phparkitect-php#166). Six of the eight app providers
do not
obey the rule, because they carry a bare type name such as
`ServiceProvider`.
PHPArkitect reports 6 violations, and the dependency pull request #215
fails on
them.

This pull request renames every app provider to carry its component
name. It also
renames `HttpRouteProvider` and `CliRouteProvider`, which already obey
the rule,
so that all eight providers read the same way.

The names take the `App` prefix that `architecture/AGENTS.md` §4
specifies for an
app-defined provider. That section names a bare `HttpServiceProvider` as
an
incorrect name, so the rename gives `AppHttpServiceProvider`.

The pull request bumps `.github/ci/phparkitect` to `^26.6.0` in the same
change.
The bump is what makes the check run the new rule. Without it, this
branch
installs v26.5.1 from the lock file, and CI passes without ever testing
the
rename. Pull request #215 keeps its own bump; that diff becomes empty
after a
rebase, and the check turns green.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/src/App/Http/Provider/`** — renamed `ComponentProvider`,
  `DataServiceProvider`, `ServiceProvider`, and `HttpRouteProvider` to
  `AppHttpComponentProvider`, `AppHttpDataServiceProvider`,
  `AppHttpServiceProvider`, and `AppHttpRouteProvider`
- **`app/src/App/Cli/Provider/`** — renamed `ComponentProvider`,
  `DataServiceProvider`, `ServiceProvider`, and `CliRou... (continued)

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Source Files on job 30725766232.1