stores-com / dhl-ecommerce-solutions / 30475014794 / 1

100%

main: 100%

Pull #11

github

Parse successful responses with response.json()

Coveralls fails this PR on any coverage decrease, and it dropped 1.0% to 98.956%. The
uncovered lines were the raw-text fallback I had added to parseResponse to mirror what
the request module did with `json: true`.

That fallback is not load-bearing. Every endpoint this SDK calls answers with JSON:
downloadManifest is asserted on `response.errorCode` / `response.errorDescription`,
createLabel returns its PNG base64 inside a JSON envelope, and the rest are plain JSON
objects. Nothing exercised the text path, which is exactly why it was uncovered.

Using `await res.json()` is also what nodejs:request-to-fetch prescribes, so this drops
the last place the implementation diverged from the skill.

Behaviour change worth a release note: a 200 whose body is not valid JSON now throws a
SyntaxError where request would have handed back the raw string. No DHL endpoint does
this today.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

79 of 79 branches covered (100.0%)

Branch coverage included in aggregate %.

295 of 295 relevant lines covered (100.0%)

22.67 hits per line