valkyrjaio / sindri-java / 30375996612 / 1

100%

26.x: 100%

push

github

[Http] Use the Java-native anchored regex form in the imperative route fixture (#56)

# Description

`GenerateDataFromConfigCommandTest`'s imperative-`getRoutes()` fixture
declares a
hand-written `DynamicRoute` regex, `/^\/manual\/(?<id>\d+)$/`. Sindri
passes a
hand-written regex through verbatim (`GenerateDataFromAst` reads
argument 2 and
emits it unchanged), so the fixture is modelling what a developer would
actually
type in a provider's `getRoutes()`.

Since v26.4.0 the framework stores dynamic route regexes as Java-native
anchored
patterns — `Regex.START` / `Regex.END` are now `^` / `$`, and `Matcher`
compiles
the stored regex directly instead of stripping PCRE delimiters first. A
regex
still carrying the `/…/` framing would no longer match anything at
runtime, so
no Java app would write one. The fixture is the only place in the repo
still
spelling it that way, which makes it read as the supported form.

Nothing asserts this value, so this is purely a fidelity fix to the
fixture; the
pass-through behaviour it exercises is unchanged. `./gradlew ci` passes.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`GenerateDataFromConfigCommandTest.java`** — the `manual.show`
fixture route
  now carries `^\/manual\/(?<id>\d+)$` instead of the PCRE-delimited
`/^\/manual\/(?<id>\d+)$/`, with a comment noting that a hand-written
regex is
emitted verbatim and so must use the form the framework itself now
produces.

526 of 527 branches covered (99.81%)

Branch coverage included in aggregate %.

1515 of 1515 relevant lines covered (100.0%)

4.39 hits per line