valkyrjaio / valkyrja-ts / 30186185023 / 1

100%

26.x: 100%

push

github

[Http] Add HTTP serving provider stack and enable request dispatch (#82)

# Description

Builds out the HTTP serving dependency-injection provider stack so an
HTTP
application can actually boot and dispatch a request in TypeScript.
Until now the
CLI side had a complete provider stack (Interaction, Middleware,
Routing, Server)
but the HTTP side had none — nothing registered the `RequestHandler`,
the HTTP
router/dispatch, or the HTTP middleware handlers — so `Http.run()` could
never
resolve its request handler. The framework's own functional Http test
documented
request-running as a known gap ("TS has no attributes/Env, so
request-running is
a documented gap").

This ports the missing HTTP provider stack from the PHP framework
(adapted to the
subsystems that exist in the TS port today) and fixes two defects that
prevented
HTTP dispatch from working end to end:

- `Application\Kernel\Valkyrja::getProviders()` only expanded one level
of nested
component providers, so a component provider that composes other
component
providers (the normal application-provider structure) never registered
its
  children at runtime. Ported PHP's recursive `collectProviders`.
- `Http\Server\Handler\RequestHandler::dispatchRouter()` distinguished a
returned
request from a returned response with `'getPath' in x`, but a
`ServerRequest`
has no `getPath` — so every request was misclassified as a response and
returned
without ever being dispatched. It now checks `'getStatusCode'`, matching
PHP's
  `instanceof ResponseContract`.

A debug-mode application discovers its routes at runtime from the
registered HTTP
route providers, so the stack functions against an empty data cache (no
generated
routing data required).

Scope note — deliberately not ported because the corresponding
subsystems are not
in the TS port yet: attribute/reflection route collection (only explicit
`getRoutes()` routes are discovered), and the Log/View server middleware
(`LogThrowableCaught`, `ViewThrowableCaught`... (continued)

1580 of 1580 branches covered (100.0%)

Branch coverage included in aggregate %.

3457 of 3457 relevant lines covered (100.0%)

21.05 hits per line