1
67%
master: 67%

Ran 23 Sep 2016 06:17PM UTC

Files 7

Run time 1s

Badge

Embed ▾

Committed 23 Sep 2016 06:12PM UTC coverage: 63.455% (+0.2%) from 63.261%

Job # EVM_EMACS=emacs-24.4-bin

Build Type

Pull #651

travis-ci

Committed by

web-flow

Commit Message

Fix autoskipping closing chevrons in rust-mode

Before this commit, closing chevrons were not autoskipped.  Typing:

`T<` would result in the correct insertion of a matching closing
chevron: `T<|>`, but typing `>` would not result in `T<>|>`, not
skipping the closing chevron even with the `autoskip` action set on the
pair.

This was caused by the regexp in `sp-rust-could-be-parameterized` set as
a `when` filter for the local pair "<" ">".  This filter is called by
`sp--do-action-p` not only when inserting a chevron, but also when
determining if the closing chevron should be autoskipped.  In the
closing case, the regexp does not match, because at the moment this
check is done the code contains one extra chevron: `<T>|>`.

In fact, the filter `sp-rust-could-be-parameterized` was implicitly
concerned only with the `insert` action, and not the other ones.

This commits rewrites the filter to explicitly disallow some cases where
a matching bracket should not be inserted.

Closes #642.

Pull Request Pull Request #651: Fix autoskipping closing chevrons in rust-mode

Coverage Stats

2358 of 3716 relevant lines covered (63.46%)

3107.21 hits per line

Fuco1 / smartparens / 910 / 1
67%
master: 67%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 910.1 (EVM_EMACS=emacs-24.4-bin)

Fuco1 / smartparens / 910 / 1 67% master: 67%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 910.1 (EVM_EMACS=emacs-24.4-bin)

Fuco1 / smartparens / 910 / 1
67%
master: 67%

README BADGES
x