umputun / revdiff / 29454613411 / 1
90%
master: 90%

LAST BUILD BRANCH: signal-safe-annotation-save
DEFAULT BRANCH: master
Ran
Files 74
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.934%. Remained the same
29454613411.1

Pull #263

github

kylesnowschwartz 
feat(launch): run tmux reviews in a detached session with popup attach

The tmux backend previously ran revdiff directly inside display-popup,
so closing the popup killed the review. Now the launcher creates a
detached session (revdiff-<pid>) running revdiff and opens the popup as
a client attached to it: detaching backgrounds the review with all
state intact, and completion is signalled by a sentinel file (the same
pattern the zellij/kitty backends use) instead of popup exit.

Session handling details:
- follow-up tmux calls target the session ID from new-session -P -F,
  since name targets prefix-match and set-option rejects the = prefix
- per-session options: status off, detach-on-destroy on,
  destroy-unattached off, and @revdiff_title stashed for custom
  reattach bindings
- INT/TERM traps kill the invisible session so a cancelled launcher
  cannot leak it
- a failing display-popup (tmux < 3.2) kills the session and exits
  instead of waiting forever on the sentinel

New REVDIFF_TMUX_SESSION_OPTIONS env var applies user-supplied
key=value pairs as session options before any client attaches, so
external session tooling (status bars, session managers, dashboards)
can tag and recognize the transient review session.

The fake tmux test backend gains new-session/set-option/has-session/
attach-session handling; the plan-review launcher intentionally keeps
the direct-popup form (it creates no session to background).
Pull Request #263: feat(launch): run tmux reviews in a detached session so the popup can be backgrounded

10838 of 12051 relevant lines covered (89.93%)

2974.1 hits per line

Source Files on job 29454613411.1