dangernoodle-io / breadboard / 29357245975 / 1

96%

main: 96%

push

github

refactor: migrate bb_system/bb_diag off bb_nv generic KV (B1-756) (#866)

Moves the final two bb_nv generic-KV consumers onto bb_config (the typed
layer over bb_storage), following PRs #864/#865's pattern -- this closes out
the bb_nv dissolution epic B1-708's consumer-migration slices.

Preserved namespaces/keys/types (byte-compatible on-flash, no format change
-- bb_nv's ESP-IDF forwarders and bb_config's typed encodings both resolve
to the same underlying bb_storage_nvs_*/nvs_* calls):
  - bb_system: ns "bb_reboot" (BB_REBOOT_NVS_NS), key "boot_cnt"
    (BB_REBOOT_KEY_BOOT_CNT) -- U8 boot-health counter
    (bb_system_boot_count_increment/_reset)
  - bb_diag: ns "bb_reboot" (BB_REBOOT_NVS_NS), keys "last"
    (BB_REBOOT_KEY_LAST) and "history" (BB_REBOOT_KEY_HISTORY) -- both
    STR-typed reboot-reason SSOT fields (load_reboot_record's single
    clear-on-read record and the rolling 8-entry history ring)

NUL-termination (B1-756 trap 1): both bb_diag destination buffers
(load_reboot_record's buf/hist_buf) are zero-initialized (= {0}) before
their bb_config_get_str calls, so no explicit termination fix was needed --
unlike bb_tls_creds/bb_net_health in prior slices. bb_system's counter is a
scalar (U8), not a string, so no NUL-termination concern applies there
either.

Host test coverage (B1-756 trap 3): bb_system's existing boot-count host
tests (test_bb_system_boot_count_increment/_reset/_overflow) exercise
platform/host/bb_system/bb_system_host.c's own independent in-memory
s_boot_count stand-in, not bb_nv at all -- host has no reboot-persistent
storage by design (see that file's existing comment), so they were never
asserting anything about bb_nv's persistence -- they simply never touched
it. platform/espidf/bb_system/bb_system.c (the file migrated here) is
ESP-IDF-only and was never host-compiled or coverage-measured before this
change, and remains so after -- migrating its bb_nv calls to bb_config does
not create a new host-testable round-trip ... (continued)

6899 of 7537 branches covered (91.54%)

Branch coverage included in aggregate %.

11596 of 11865 relevant lines covered (97.73%)

2401.88 hits per line