ben-manes / caffeine / #5634 / 1

100%

master: 100%

push

github

Fix the timer wheel wrap bias at Long.MIN_VALUE

advance()'s negative-to-non-negative crossing rebiases the timestamps so
the unsigned per-level tick delta is correct. The bias must be 2^63 to
map the negative range [MIN_VALUE, -1] strictly below the non-negative
range in unsigned space. Biasing by Long.MAX_VALUE (2^63-1) is one short:
previousTimeNanos == Long.MIN_VALUE maps to unsigned 2^64-1 instead of 0,
so every wheel delta is <= 0, the loop breaks at level 0, and the whole
advance is a no-op (background expiration stalls until the next advance
with a non-degenerate previous; the read path stays exact). Bias by
Long.MIN_VALUE, whose bit pattern is 2^63.

4137 of 4148 branches covered (99.73%)

8412 of 8413 relevant lines covered (99.99%)

1.0 hits per line