archetech / archon / 28612079896 / 1

92%

main: 92%

Pull #676

github

fix(gatekeeper): proper error classification on /1.0/identifiers; spec wording

Address Copilot review feedback on the conformant surface:

- The three /1.0/identifiers handlers previously mapped every thrown error
  to 404 "DID not found", masking real failures. Add classifyResolveError():
  an InvalidOperationError (a bad proof surfaced by the hardcoded verify is
  the DID's problem, not the server's) -> 404 notFound; anything else ->
  500 internalError, logged. The resolve endpoint reports the error in
  didResolutionMetadata, keeping the result triple-shaped; the dereference
  endpoints return { error }. resolveConformant() still handles the expected
  invalidDid/notFound cases before the catch.
- scheme.md: a deactivated DID's didDocument is reduced to just its `id`,
  not "set to empty" (matched the example, which shows an id).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2897 of 3414 branches covered (84.86%)

Branch coverage included in aggregate %.

11594 of 12176 relevant lines covered (95.22%)

444.68 hits per line