alma-oss / spirit-design-system / 28442399979 / 2

86%

main: 85%

Pull #2444

github

feat(web-react)!: add `CloseButton` and remove component-specific close buttons #DS-2216

Introduce a shared `CloseButton` built on `ControlButton`. It owns the close
icon, the visually hidden label with i18n fallback, and the symmetrical
icon-only layout, so consumers only wire up their own size, handler, and ARIA
props.

Remove the three component-specific close buttons (`DrawerCloseButton`,
`ModalCloseButton`, `TooltipCloseButton`) in favor of `CloseButton`.
`ModalHeader` and `TooltipPopover` now render `CloseButton` internally;
`DrawerPanel` keeps its `closeButton` prop, with consumers passing a
manually-wired `CloseButton`.

Add the `v5/web-react/close-buttons-to-close-button` codemod (fully migrates
`ModalCloseButton` and `TooltipCloseButton`, and scaffolds `DrawerCloseButton`
into `CloseButton` with `TODO_*` placeholder props to finish wiring) and a
migration guide section.

BREAKING CHANGE: `DrawerCloseButton`, `ModalCloseButton`, `TooltipCloseButton`, and
their prop types are removed. Use `CloseButton` instead.

666 of 993 branches covered (67.07%)

Branch coverage included in aggregate %.

1112 of 1260 relevant lines covered (88.25%)

3.98 hits per line